]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: mux-h1: H2 preface rejection doesn't update stick-table glitches
authorChad Lavoie <clavoie@haproxy.com>
Fri, 22 May 2026 17:58:38 +0000 (13:58 -0400)
committerChristopher Faulet <cfaulet@haproxy.com>
Wed, 27 May 2026 08:53:00 +0000 (10:53 +0200)
commit8d771110e08ca3fa2f99158c83e9abd0724bdd52
treef0ee9b92850244416575b60ba60128e955034d37
parent85a833feba0e631eea225e768461a6e0880397a4
BUG/MINOR: mux-h1: H2 preface rejection doesn't update stick-table glitches

commit 72fd357814e1 ("MEDIUM: mux-h1: Return an error on h2 upgrade
attempts if not allowed") added an h1_report_glitch() call on the new
405 path but exits via "goto no_parsing", which skips the
session_add_glitch_ctr() call at the end of the parse block. As a
result fc_glitches increments correctly but the per-session stick
counters never see it, breaking sc_glitch_cnt-based rate limiting of
the H2-preface-over-H1 abuse pattern.

No backport needed beyond the branches that took 72fd357814.

[cf: Patch was edited to move the goto label instead of duplicating
     the call to session_add_glitch_ctr]
src/mux_h1.c