]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
wifi: rtlwifi: 8192de: correct checking of IQK reload
authorPing-Ke Shih <pkshih@realtek.com>
Mon, 1 Aug 2022 11:33:45 +0000 (19:33 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 Jun 2023 08:29:04 +0000 (10:29 +0200)
commit914bf541c3bb8a87f6930ab0a3d49b4914b0c517
treed8301e7adc143515e2ea1f95c4b8854a5b12afef
parent58bc9baaef925e41f8b43d0e7f1e929f7af3628e
wifi: rtlwifi: 8192de: correct checking of IQK reload

commit 93fbc1ebd978cf408ef5765e9c1630fce9a8621b upstream.

Since IQK could spend time, we make a cache of IQK result matrix that looks
like iqk_matrix[channel_idx].val[x][y], and we can reload the matrix if we
have made a cache. To determine a cache is made, we check
iqk_matrix[channel_idx].val[0][0].

The initial commit 7274a8c22980 ("rtlwifi: rtl8192de: Merge phy routines")
make a mistake that checks incorrect iqk_matrix[channel_idx].val[0] that
is always true, and this mistake is found by commit ee3db469dd31
("wifi: rtlwifi: remove always-true condition pointed out by GCC 12"), so
I recall the vendor driver to find fix and apply the correctness.

Fixes: 7274a8c22980 ("rtlwifi: rtl8192de: Merge phy routines")
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220801113345.42016-1-pkshih@realtek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c