]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Avoid using ambiguous word "non-negative" in error messages.
authorFujii Masao <fujii@postgresql.org>
Tue, 27 Jul 2021 16:21:52 +0000 (01:21 +0900)
committerFujii Masao <fujii@postgresql.org>
Tue, 27 Jul 2021 16:21:52 +0000 (01:21 +0900)
commit92913fc290f3adb3fe937485474a11ac6708e4b0
tree7f6c29c53195d0eca6c0d602d93132f726bbe38b
parentd629fcf4b36ca8c1e4e9677745ff7d725433ee19
Avoid using ambiguous word "non-negative" in error messages.

The error messages using the word "non-negative" are confusing
because it's ambiguous about whether it accepts zero or not.
This commit improves those error messages by replacing it with
less ambiguous word like "greater than zero" or
"greater than or equal to zero".

Also this commit added the note about the word "non-negative" to
the error message style guide, to help writing the new error messages.

When postgres_fdw option fetch_size was set to zero, previously
the error message "fetch_size requires a non-negative integer value"
was reported. This error message was outright buggy. Therefore
back-patch to all supported versions where such buggy error message
could be thrown.

Reported-by: Hou Zhijie
Author: Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Fujii Masao
Discussion: https://postgr.es/m/OS0PR01MB5716415335A06B489F1B3A8194569@OS0PR01MB5716.jpnprd01.prod.outlook.com
contrib/postgres_fdw/option.c
doc/src/sgml/sources.sgml
src/backend/partitioning/partbounds.c
src/backend/utils/adt/tsquery_op.c
src/test/modules/test_shm_mq/test.c
src/test/regress/expected/hash_part.out