]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Revert "btrfs: Honour FITRIM range constraints during free space trim"
authorDavid Sterba <dsterba@suse.com>
Wed, 29 May 2019 17:25:47 +0000 (19:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 31 May 2019 13:43:13 +0000 (06:43 -0700)
commit93d91ef889548c3527846fb469b4ec6d8ffa4ad9
treeba4e2a374a08eb004a93436cc753b44bdcf2f0c3
parentdc9ddd15e921697e05d37af38752091a90f6c5b3
Revert "btrfs: Honour FITRIM range constraints during free space trim"

This reverts commit eb432217d775a90c061681c0dfa3c7abfba75123.

There is currently no corresponding patch in master due to additional
changes that would be significantly different from plain revert in the
respective stable branch.

The range argument was not handled correctly and could cause trim to
overlap allocated areas or reach beyond the end of the device. The
address space that fitrim normally operates on is in logical
coordinates, while the discards are done on the physical device extents.
This distinction cannot be made with the current ioctl interface and
caused the confusion.

The bug depends on the layout of block groups and does not always
happen. The whole-fs trim (run by default by the fstrim tool) is not
affected.

Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/extent-tree.c