]> git.ipfire.org Git - thirdparty/bind9.git/commit
Don't enable timeouts in dns_dispatch for incoming transfers
authorOndřej Surý <ondrej@isc.org>
Fri, 20 Sep 2024 13:13:09 +0000 (15:13 +0200)
committerOndřej Surý <ondrej@isc.org>
Sat, 21 Sep 2024 08:15:47 +0000 (10:15 +0200)
commit96ef98558c7df1b5949acf867d79ca3815dcb095
tree7df01690b2210db76c849be0fd6b53e0772f7e20
parent0f810b3144866f45413c109275210637e4425432
Don't enable timeouts in dns_dispatch for incoming transfers

The dns_dispatch_add() call in the dns_xfrin unit had hardcoded 30
second limit.  This meant that any incoming transfer would be stopped in
it didn't finish within 30 seconds limit.  Additionally, dns_xfrin
callback was ignoring the return value from dns_dispatch_getnext() when
restarting the reading from the TCP stream; this could cause transfers
to get stuck waiting for a callback that would never come due to the
dns_dispatch having already been shut down.

Call the dns_dispatch_add() without a timeout and properly handle the
result code from the dns_dispatch_getnext().
lib/dns/xfrin.c