]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ena: fix napi handler misbehavior when the napi budget is zero
authorNetanel Belgazal <netanel@amazon.com>
Tue, 10 Dec 2019 11:27:44 +0000 (11:27 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 Jan 2020 12:41:11 +0000 (13:41 +0100)
commit971932afde4ee53a7d386e898db0021111e0603b
treeb603206467e3db25d2e765e6869a2634dfa4adf9
parentb524e0caa40e2e3951e9da188bb7ba32007b4cf2
net: ena: fix napi handler misbehavior when the napi budget is zero

[ Upstream commit 24dee0c7478d1a1e00abdf5625b7f921467325dc ]

In netpoll the napi handler could be called with budget equal to zero.
Current ENA napi handler doesn't take that into consideration.

The napi handler handles Rx packets in a do-while loop.
Currently, the budget check happens only after decrementing the
budget, therefore the napi handler, in rare cases, could run over
MAX_INT packets.

In addition to that, this moves all budget related variables to int
calculation and stop mixing u32 to avoid ambiguity

Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Netanel Belgazal <netanel@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/amazon/ena/ena_netdev.c