]> git.ipfire.org Git - thirdparty/linux.git/commit
net: dsa: sja1105: reorder sja1105_reload_cbs() and phylink_replay_link_end()
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 4 Mar 2026 22:08:59 +0000 (00:08 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Mar 2026 01:48:01 +0000 (17:48 -0800)
commit976703cae7375898b445fc40d14faf849e916a4b
tree38b245fd9d32878f5635046f4be0ca156a63172c
parent0cc0c2e661af418bbf7074179ea5cfffc0a5c466
net: dsa: sja1105: reorder sja1105_reload_cbs() and phylink_replay_link_end()

Move phylink_replay_link_end() as the last locked operation under
sja1105_static_config_reload(). The purpose is to be able to goto
this step from the error path of intermediate steps (we must call
phylink_replay_link_end()).

sja1105_reload_cbs() notably does not depend on port states or link
speeds. See commit 954ad9bf13c4 ("net: dsa: sja1105: fix bandwidth
discrepancy between tc-cbs software and offload") which has discussed
this issue specifically.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20260304220900.3865120-2-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/sja1105/sja1105_main.c