]> git.ipfire.org Git - thirdparty/linux.git/commit
ALSA: firewire-motu: Protect register DSP event queue positions
authorCássio Gabriel <cassiogabrielcontato@gmail.com>
Thu, 21 May 2026 11:01:23 +0000 (08:01 -0300)
committerTakashi Iwai <tiwai@suse.de>
Mon, 25 May 2026 07:19:44 +0000 (09:19 +0200)
commit98fb1c1bb11e29eb609b7200a25e136e05aa4498
tree526726b26739abe0c10b829861a2235ec27220a6
parent2519003dd5fb6f89f10f031e3a97ecb7c9d1b816
ALSA: firewire-motu: Protect register DSP event queue positions

The register DSP event queue is updated under parser->lock, but
snd_motu_register_dsp_message_parser_count_event() reads pull_pos and
push_pos without the lock.
snd_motu_register_dsp_message_parser_copy_event() also reads both queue
positions before taking the lock.

Protect these accesses with parser->lock as well. This keeps the hwdep
poll/read path consistent with the producer side and with the cached
meter/parameter accessors.

Fixes: 634ec0b2906e ("ALSA: firewire-motu: notify event for parameter change in register DSP model")
Cc: stable@vger.kernel.org
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20260521-alsa-firewire-motu-event-locking-v1-1-708e1c2b5e56@gmail.com
sound/firewire/motu/motu-register-dsp-message-parser.c