]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net/smc: Do not re-initialize smc hashtables
authorAlexandra Winter <wintera@linux.ibm.com>
Thu, 21 May 2026 14:56:39 +0000 (16:56 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 23 May 2026 00:38:02 +0000 (17:38 -0700)
commit9e4389b0038781f19f97895186ed941ff8ac1678
treece1915add7e81e2d6769d2b84b544de210884216
parentf54ea9ba95b8002d62fe0fb3b3cbe1b6dbdaf5a9
net/smc: Do not re-initialize smc hashtables

INIT_HLIST_HEAD(&smc_v*_hashinfo.ht) are called after smc_nl_init(),
proto_register() and sock_register(). This can lead to smc_v*_hashinfo.ht
being reset even though hash entries already exist and are being used,
possibly resulting in a corrupted list.

Remove unnecessary and dangerous re-initialisation of smc_v*_hashinfo.ht in
smc_init(); it is implicitly initialised to zero anyhow. Add
HLIST_HEAD_INIT to the definitions for clarity.

Fixes: f16a7dd5cf27 ("smc: netlink interface for SMC sockets")
Suggested-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Reviewed-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
Link: https://patch.msgid.link/20260521145639.10317-1-wintera@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/smc/af_smc.c