]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
wifi: b43legacy: enforce bounds check on firmware key index in RX path
authorTristan Madani <tristan@talencesecurity.com>
Fri, 17 Apr 2026 11:11:45 +0000 (11:11 +0000)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 27 Apr 2026 10:39:57 +0000 (12:39 +0200)
commita035766f970bde2d4298346a31a80685be5c0205
treeb04223006da8f95c7e85ff65398a6c8f94f1996b
parent1f4f78bf8549e6ac4f04fba4176854f3a6e0c332
wifi: b43legacy: enforce bounds check on firmware key index in RX path

Same fix as b43: the firmware-controlled key index in b43legacy_rx()
can exceed dev->max_nr_keys. The existing B43legacy_WARN_ON is
non-enforcing in production builds, allowing an out-of-bounds read of
dev->key[].

Make the check enforcing by dropping the frame for invalid indices.

Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
Cc: stable@vger.kernel.org
Signed-off-by: Tristan Madani <tristan@talencesecurity.com>
Link: https://patch.msgid.link/20260417111145.2694196-2-tristmd@gmail.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/broadcom/b43legacy/xmit.c