]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mfd: macsmc: Initialize mutex
authorJanne Grunau <j@jannau.net>
Wed, 31 Dec 2025 09:42:12 +0000 (10:42 +0100)
committerSasha Levin <sashal@kernel.org>
Wed, 4 Mar 2026 12:21:12 +0000 (07:21 -0500)
commita1e9e299c0d9ea42ab1067b39fb72e976d3f1bdb
treed699f55c6b48d36e4fde1392400561675b9a13d0
parent89bdcd39ae8b1ffd7000897b30d152729b68d49d
mfd: macsmc: Initialize mutex

[ Upstream commit 414f65d6736342c77d4ec5e7373039f4a09250dd ]

Initialize struct apple_smc's mutex in apple_smc_probe(). Using the
mutex uninitialized surprisingly resulted only in occasional NULL
pointer dereferences in apple_smc_read() calls from the probe()
functions of sub devices.

Cc: stable@vger.kernel.org
Fixes: e038d985c9823 ("mfd: Add Apple Silicon System Management Controller")
Signed-off-by: Janne Grunau <j@jannau.net>
Reviewed-by: Sven Peter <sven@kernel.org>
Reviewed-by: Neal Gompa <neal@gompa.dev>
Link: https://patch.msgid.link/20251231-macsmc-mutex_init-v2-1-5818c9dc9b29@jannau.net
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mfd/macsmc.c