]> git.ipfire.org Git - thirdparty/bind9.git/commit
projects / thirdparty / bind9.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3f85b0f) | patch
Cast the original rcode to (dns_ttl_t) when setting extended rcode
authorMark Andrews <marka@isc.org>
Tue, 25 Aug 2020 12:59:35 +0000 (22:59 +1000)
committerOndřej Surý <ondrej@isc.org>
Tue, 25 Aug 2020 14:10:05 +0000 (14:10 +0000)
commita347641782dfb47aa45e6e8ffc9e0c6db4c07deb
tree5eaaee3cefb54a9b2e4542ecd2fc202fe277e900tree | snapshot
parent3f85b0fe3b4f292bc8a40d2897218751ec2d4041commit | diff
Cast the original rcode to (dns_ttl_t) when setting extended rcode

Shifting (signed) integer left could trigger undefined behaviour when
the shifted value would overflow into the sign bit (e.g. 2048).

The issue was found when using AFL++ and UBSAN:

    message.c:2274:33: runtime error: left shift of 2048 by 20 places cannot be represented in type 'int'
    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior message.c:2274:33 in
lib/dns/message.c diff | blob | blame | history
Mirror of https://gitlab.isc.org/isc-projects/bind9.git