]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ovl: Copy up underlying inode's ->i_mode to overlay inode
authorVivek Goyal <vgoyal@redhat.com>
Fri, 1 Jul 2016 20:34:25 +0000 (16:34 -0400)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 8 Aug 2016 01:44:56 +0000 (21:44 -0400)
commita3638d4fdf49046a09a71d9ce8c426bbfd37fbbc
tree4ee6d735e6578f80f376ec5cd7c3cf813f349840
parentd4e1ac55843e799890318798794d7e6b48a68d4c
ovl: Copy up underlying inode's ->i_mode to overlay inode

[ Upstream commit 07a2daab49c549a37b5b744cbebb6e3f445f12bc ]

Right now when a new overlay inode is created, we initialize overlay
inode's ->i_mode from underlying inode ->i_mode but we retain only
file type bits (S_IFMT) and discard permission bits.

This patch changes it and retains permission bits too. This should allow
overlay to do permission checks on overlay inode itself in task context.

[SzM] It also fixes clearing suid/sgid bits on write.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Reported-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay")
Cc: <stable@vger.kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
fs/overlayfs/inode.c
fs/overlayfs/overlayfs.h