]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Fix validation of PCI option rom settings on hotplug
authorPeter Krempa <pkrempa@redhat.com>
Thu, 25 Nov 2021 15:17:16 +0000 (16:17 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 26 Nov 2021 09:02:32 +0000 (10:02 +0100)
commita453ebcd2bfb63ba3fc85e9c39bcdcf47c3d9f1c
tree6bed7c860de13f73fee886fce81be44d0ee5ea18
parentd120fc5253f620a6a76cfb15f1e09337e8b3d926
qemu: Fix validation of PCI option rom settings on hotplug

Commit 24be92b8e moved the option rom settings validation code to the
validation callbacks, but that doesn't work properly with device hotplug
as we assign addresses only after parsing the whole XML. The check is
too strict for that and caused failures when hotplugging devices such
as:

 <interface type='network'>
   <source network='default'/>
   <model type='virtio'/>
   <rom enabled='no'/>
 </interface>

This patch relaxes the check in the validation callback to accept also
_NONE and _UNASSIGNED address types and returns the check to
'qemuBuildRomProps' so that we preserve the full validation as we've
used to.

Fixes: 24be92b8e38762e9ba13e
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2021437
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_command.c
src/qemu/qemu_validate.c