]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Input: drv260x - fix input device's parent assignment
authorJingkui Wang <jkwang@google.com>
Mon, 12 Dec 2016 21:51:46 +0000 (13:51 -0800)
committerSasha Levin <alexander.levin@verizon.com>
Fri, 13 Jan 2017 01:56:57 +0000 (20:56 -0500)
commita62e45871b7b8e69a6fe62a0d2b812bb1156658a
tree60e2672b5c95345ca06c5eb7f7dd168890114d91
parente1589b27ffb95ef8286dee5c2a2e4f7ab97763cd
Input: drv260x - fix input device's parent assignment

[ Upstream commit 5a8a6b89c15766446d845671d574a9243b6d8786 ]

We were assigning I2C bus controller instead of client as parent device.
Besides being logically wrong, it messed up with devm handling of input
device. As a result we were leaving input device and event node behind
after rmmod-ing the driver, which lead to a kernel oops if one were to
access the event node later.

Let's remove the assignment and rely on devm_input_allocate_device() to
set it up properly for us.

Signed-off-by: Jingkui Wang <jkwang@google.com>
Fixes: 7132fe4f5687 ("Input: drv260x - add TI drv260x haptics driver")
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/input/misc/drv260x.c