]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
flow_dissector: fix byteorder of dissected ICMP ID
authorAlexander Lobakin <alobakin@pm.me>
Fri, 12 Mar 2021 20:08:57 +0000 (20:08 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Mar 2021 12:30:20 +0000 (14:30 +0200)
commita6698235caf6c467ad6796b6825a4be2112d11d7
treeef9535d56dab5e28101e2112f3bfce2eddebdf5e
parent59050436a732e9d8e95544962dfe346489004240
flow_dissector: fix byteorder of dissected ICMP ID

[ Upstream commit a25f822285420486f5da434efc8d940d42a83bce ]

flow_dissector_key_icmp::id is of type u16 (CPU byteorder),
ICMP header has its ID field in network byteorder obviously.
Sparse says:

net/core/flow_dissector.c:178:43: warning: restricted __be16 degrades to integer

Convert ID value to CPU byteorder when storing it into
flow_dissector_key_icmp.

Fixes: 5dec597e5cd0 ("flow_dissector: extract more ICMP information")
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/flow_dissector.c