]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: scarlett2: Allow flash writes ending at segment boundary
authorCássio Gabriel <cassiogabrielcontato@gmail.com>
Tue, 19 May 2026 14:46:19 +0000 (11:46 -0300)
committerTakashi Iwai <tiwai@suse.de>
Wed, 20 May 2026 05:51:46 +0000 (07:51 +0200)
commita69b677e47a80319ce148d61cc29a2b57006e78d
tree1c71e9fb3771ae84cb368a4b41e4eda9370ffb77
parent12b1b4f5653d9a14980c0d881f4ac1af2e1d6b05
ALSA: scarlett2: Allow flash writes ending at segment boundary

scarlett2_hwdep_write() rejects writes when offset + count is greater than
or equal to the selected flash segment size. That incorrectly treats a
write ending exactly at the end of the segment as out of space, although
the last byte written is still within the segment.

Split invalid argument checks from the segment-space check, keep
zero-length writes as no-ops, and compare count against the remaining
segment size. This permits exact-end writes and avoids relying on
offset + count before deciding whether the request is in bounds.

Fixes: 1abfbd3c9527 ("ALSA: scarlett2: Add support for uploading new firmware")
Cc: stable@vger.kernel.org
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Link: https://patch.msgid.link/20260519-alsa-scarlett2-flash-write-boundary-v1-1-b550480e92da@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer_scarlett2.c