]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iommu/vt-d: Fix IOMMU lookup for SR-IOV Virtual Functions
authorAshok Raj <ashok.raj@intel.com>
Fri, 21 Oct 2016 22:32:05 +0000 (15:32 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 23 Feb 2017 03:54:26 +0000 (03:54 +0000)
commita6cc35756bb9ba093eae6077221e6ff6281d1bc3
tree89a2d7bddefd1705295e77928232aa0fd1dd5d17
parent37332b5bc488240c7563e689b359001315c5d365
iommu/vt-d: Fix IOMMU lookup for SR-IOV Virtual Functions

commit 1c387188c60f53b338c20eee32db055dfe022a9b upstream.

The VT-d specification (§8.3.3) says:
    ‘Virtual Functions’ of a ‘Physical Function’ are under the scope
    of the same remapping unit as the ‘Physical Function’.

The BIOS is not required to list all the possible VFs in the scope
tables, and arguably *shouldn't* make any attempt to do so, since there
could be a huge number of them.

This has been broken basically for ever — the VF is never going to match
against a specific unit's scope, so it ends up being assigned to the
INCLUDE_ALL IOMMU. Which was always actually correct by coincidence, but
now we're looking at Root-Complex integrated devices with SR-IOV support
it's going to start being wrong.

Fix it to simply use pci_physfn() before doing the lookup for PCI devices.

Signed-off-by: Sainath Grandhi <sainath.grandhi@intel.com>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/iommu/dmar.c
drivers/iommu/intel-iommu.c