]> git.ipfire.org Git - thirdparty/linux.git/commit
spi: qup: fix error pointer deref after DMA setup failure
authorJohan Hovold <johan@kernel.org>
Tue, 12 May 2026 07:43:34 +0000 (09:43 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 18 May 2026 16:36:26 +0000 (17:36 +0100)
commita7e8f3efd50a165ba0189f6dc57f7e51a7d149db
treed9baaa1d54f132181260af866954a5b2fef0f8a1
parent496ba79b9496b8b3747cbc764ebd33ee7325e806
spi: qup: fix error pointer deref after DMA setup failure

The driver falls back to PIO mode if DMA setup fails during probe.

Make sure to the clear the DMA channel pointers on setup failure to
avoid dereferencing an error pointer (or attempting to release a channel
a second time) on later probe errors or driver unbind.

This issue was flagged by Sashiko when reviewing a devres allocation
conversion patch.

Fixes: 612762e82ae6 ("spi: qup: Add DMA capabilities")
Link: https://sashiko.dev/#/patchset/20260505072909.618363-1-johan%40kernel.org?part=4
Cc: stable@vger.kernel.org # 4.1
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260512074334.914735-1-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qup.c