]> git.ipfire.org Git - thirdparty/linux.git/commit
ethtool: strset: fix header attribute index in ethnl_req_get_phydev()
authorJakub Kicinski <kuba@kernel.org>
Tue, 26 May 2026 15:35:31 +0000 (08:35 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 28 May 2026 00:42:09 +0000 (17:42 -0700)
commita8d8bef6b45bf7cc0b1f6110c5cd8d0160a9bad7
tree090df3464d4ada4901df9812cbbe99ceea2624a8
parentc3fc9976f686f9a95baf87db9d387f218fd65394
ethtool: strset: fix header attribute index in ethnl_req_get_phydev()

strset_prepare_data() passes ETHTOOL_A_HEADER_FLAGS (3) as the header
attribute to ethnl_req_get_phydev(). This is incorrect, in the main
attr space 3 is ETHTOOL_A_STRSET_COUNTS_ONLY, not the request
header attr. The correct constant is ETHTOOL_A_STRSET_HEADER (1).

ethnl_req_get_phydev() only uses this value for the extack,
so this is not a "functionally visible"(?) bug.

Fixes: e96c93aa4be9 ("net: ethtool: strset: Allow querying phy stats by index")
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20260526153533.2779187-9-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/strset.c