]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
sctp: fix addip_serial increment on ASCONF_ACK allocation failure
authorQing Luo <luoqing@kylinos.cn>
Tue, 4 Aug 2026 02:55:14 +0000 (10:55 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 5 Aug 2026 03:06:39 +0000 (20:06 -0700)
commitaa2e13ae8d3cbe2c15ef4f7e971b2de0832794aa
treeb6d39e966ba5b0456f515c31e47c62020fd2ad3e
parent6183a645aaeb17572058a8125a3ac2699ce858bb
sctp: fix addip_serial increment on ASCONF_ACK allocation failure

In sctp_process_asconf(), when sctp_make_asconf_ack() fails to allocate
the ASCONF_ACK chunk due to memory pressure, the code jumps to the
done label where asoc->peer.addip_serial is unconditionally incremented.

This leaves the peer's ASCONF (serial N) unacknowledged while the local
endpoint now expects serial N+1. When the peer retransmits serial N, it
falls into the serial < addip_serial + 1 branch ,
which attempts to look up a cached ACK for serial N. No cached ACK
exists since the allocation failed, so the retransmission is silently
discarded. The peer eventually times out and ABORTs the association.

Move the addip_serial increment inside the if (asconf_ack) block so that
the serial number is only advanced when the ASCONF_ACK is successfully
created and cached. This way, on allocation failure, the serial number
is unchanged and the peer's retransmitted ASCONF will be correctly
re-processed.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Qing Luo <luoqing@kylinos.cn>
Acked-by: Xin Long <lucien.xin@gmail.com>
Link: https://patch.msgid.link/20260804025514.241767-1-l1138897701@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sctp/sm_make_chunk.c