]> git.ipfire.org Git - thirdparty/linux.git/commit
tun: free page on build_skb failure in tun_xdp_one()
authorWeiming Shi <bestswngs@gmail.com>
Thu, 21 May 2026 16:33:13 +0000 (09:33 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 22 May 2026 17:10:07 +0000 (10:10 -0700)
commitaa8963fdce667a42fb7f0bdd2909fadcab02f9a8
treef2bfcfbdc96449b04df12059745e86ff5f8263a8
parent3bcf7aec6a9d16438f2cec29f5d7c8d5b8edf9b2
tun: free page on build_skb failure in tun_xdp_one()

When build_skb() fails in tun_xdp_one(), the function sets ret to
-ENOMEM and jumps to the out label, which returns without freeing the
page that vhost_net_build_xdp() allocated for the frame. As with the
short-frame rejection path, tun_sendmsg() discards the per-buffer error
and still returns total_len, so vhost_tx_batch() takes the success path
and never frees the page. Each build_skb() failure in a batch leaks one
page-frag chunk.

Free the page before taking the error path, matching the put_page() the
other error exits of tun_xdp_one() already perform.

Fixes: 043d222f93ab ("tuntap: accept an array of XDP buffs through sendmsg()")
Reported-by: Xiang Mei <xmei5@asu.edu>
Signed-off-by: Weiming Shi <bestswngs@gmail.com>
Reviewed-by: Dongli Zhang <dongli.zhang@oracle.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20260521163312.1479805-2-bestswngs@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/tun.c