]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
kernel: kexec: remove the lock operation of system_transition_mutex
authorBaoquan He <bhe@redhat.com>
Fri, 22 Jan 2021 07:42:14 +0000 (15:42 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Feb 2021 22:28:37 +0000 (23:28 +0100)
commitaa9a6dc6261109d72787d0b4c5bc27238ffabdbf
tree8035e4b3591994550c5cad597a828eac10427eee
parent2aa7eab3e7f0fd6188baf10bb922cb864cd93ca0
kernel: kexec: remove the lock operation of system_transition_mutex

commit 56c91a18432b631ca18438841fd1831ef756cabf upstream.

Function kernel_kexec() is called with lock system_transition_mutex
held in reboot system call. While inside kernel_kexec(), it will
acquire system_transition_mutex agin. This will lead to dead lock.

The dead lock should be easily triggered, it hasn't caused any
failure report just because the feature 'kexec jump' is almost not
used by anyone as far as I know. An inquiry can be made about who
is using 'kexec jump' and where it's used. Before that, let's simply
remove the lock operation inside CONFIG_KEXEC_JUMP ifdeffery scope.

Fixes: 55f2503c3b69 ("PM / reboot: Eliminate race between reboot and suspend")
Signed-off-by: Baoquan He <bhe@redhat.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Pingfan Liu <kernelfans@gmail.com>
Cc: 4.19+ <stable@vger.kernel.org> # 4.19+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/kexec_core.c