]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mei: bus: fix received data size check in NFC fixup
authorAlexander Usyskin <alexander.usyskin@intel.com>
Mon, 31 Oct 2016 17:02:39 +0000 (19:02 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 23 Feb 2017 03:54:26 +0000 (03:54 +0000)
commitad6dcc78333f0e2e2add0f1b350ce8d049e98ffc
treebdde6ef8fc2fe5668de40a81403aeeb96f824e1a
parent6ca68d9535acf388b07d141a743316632d8b3cbe
mei: bus: fix received data size check in NFC fixup

commit 582ab27a063a506ccb55fc48afcc325342a2deba upstream.

NFC version reply size checked against only header size, not against
full message size. That may lead potentially to uninitialized memory access
in version data.

That leads to warnings when version data is accessed:
drivers/misc/mei/bus-fixup.c: warning: '*((void *)&ver+11)' may be used uninitialized in this function [-Wuninitialized]:  => 212:2

Reported in
Build regressions/improvements in v4.9-rc3
https://lkml.org/lkml/2016/10/30/57

Fixes: 59fcd7c63abf (mei: nfc: Initial nfc implementation)
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.16:
 - Drop change in mei_phy.c
 - Adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/misc/mei/nfc.c