]> git.ipfire.org Git - thirdparty/postgresql.git/commit
postgres_fdw: Fix handling of abort-cleanup-failed connections.
authorEtsuro Fujita <efujita@postgresql.org>
Tue, 5 May 2026 09:55:03 +0000 (18:55 +0900)
committerEtsuro Fujita <efujita@postgresql.org>
Tue, 5 May 2026 09:55:03 +0000 (18:55 +0900)
commitaf8f9248fbe72f8c19f4f20daf38495afdd0a26b
treecbb82d44e862776be117396746ebfaf0249b9c89
parent13226050e85d27759c20786504efe9f5994f41ee
postgres_fdw: Fix handling of abort-cleanup-failed connections.

As connections that failed abort cleanup can't safely be further used,
if a remote query tries to get such a connection, we reject it.
Previously, this rejection involved dropping the connection if it was
open, without accounting for the possibility of open cursors using it,
causing a server crash when such an open cursor tried to use an
already-dropped connection, as a cursor-handling function
(create_cursor, fetch_more_data, or close_cursor) was called on a freed
PGconn.  To fix, delay dropping failed connections until abort cleanup
of the main transaction, to ensure open cursors using such a connection
can safely refer to the PGconn for it.

Oversight in commit 8bf58c0d9.

Reported-by: Zhibai Song <songzhibai1234@gmail.com>
Diagnosed-by: Zhibai Song <songzhibai1234@gmail.com>
Author: Etsuro Fujita <etsuro.fujita@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com>
Discussion: https://postgr.es/m/CAPmGK176y6JP017-Cn%2BhS9CEJx_6iVhRoYbAqzuLU4d8-XPPNg%40mail.gmail.com
Backpatch-through: 14
contrib/postgres_fdw/connection.c
contrib/postgres_fdw/expected/postgres_fdw.out
contrib/postgres_fdw/sql/postgres_fdw.sql