]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: mvneta: set real interrupt per packet for tx_done
authorDmitri Epshtein <dima@marvell.com>
Wed, 6 Jul 2016 02:18:58 +0000 (04:18 +0200)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 8 Aug 2016 01:47:17 +0000 (21:47 -0400)
commitb001c42aec27c92fa3cc423fb1ebc41f7033231a
tree19f5f63485e00cd1911ccaa9a2e8070803e39fd3
parent77dee6b71989b05fa3bcbcc360e26bb7928098cb
net: mvneta: set real interrupt per packet for tx_done

[ Upstream commit 06708f81528725148473c0869d6af5f809c6824b ]

Commit aebea2ba0f74 ("net: mvneta: fix Tx interrupt delay") intended to
set coalescing threshold to a value guaranteeing interrupt generation
per each sent packet, so that buffers can be released with no delay.

In fact setting threshold to '1' was wrong, because it causes interrupt
every two packets. According to the documentation a reason behind it is
following - interrupt occurs once sent buffers counter reaches a value,
which is higher than one specified in MVNETA_TXQ_SIZE_REG(q). This
behavior was confirmed during tests. Also when testing the SoC working
as a NAS device, better performance was observed with int-per-packet,
as it strongly depends on the fact that all transmitted packets are
released immediately.

This commit enables NETA controller work in interrupt per sent packet mode
by setting coalescing threshold to 0.

Signed-off-by: Dmitri Epshtein <dima@marvell.com>
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Cc: <stable@vger.kernel.org> # v3.10+
Fixes aebea2ba0f74 ("net: mvneta: fix Tx interrupt delay")
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/net/ethernet/marvell/mvneta.c