]> git.ipfire.org Git - thirdparty/samba.git/commit
pytest: samba-tool dns: allow valid updates
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 17 Jun 2021 10:22:46 +0000 (22:22 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 22 Jun 2021 01:14:37 +0000 (01:14 +0000)
commitb2453a0f5c2fbb0c002ebb5fd274ca57ff66ee9f
tree8c6a9fb83e29dc859cf6fb831135e37219bf9915
parent6fb83b454ccac7e01ab0f5d48c1c5b6a66bea173
pytest: samba-tool dns: allow valid updates

Without this patch we will get errors like this when in-place RPC
updates start to work:

   AssertionError: unexpectedly None : Successfully updated record
   '192.168.0.1' to '192.168.0.1', even though the latter is of type
   'A' where 'A' was expected.

That's because we have always rejected updates that try to modify an
existing record. We shouldn't.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/samba_tool/dnscmd.py