]> git.ipfire.org Git - thirdparty/linux.git/commit
nfc: llcp: Fix use-after-free race in nfc_llcp_recv_cc()
authorLee Jones <lee@kernel.org>
Wed, 29 Apr 2026 13:40:42 +0000 (13:40 +0000)
committerDavid Heidelberg <david@ixit.cz>
Tue, 5 May 2026 09:37:11 +0000 (11:37 +0200)
commitb493ea2765cc17cb8aa7e7544a4b6dcb05b6ed77
tree023cb3220db63b800a19eb786182b75ba9bb2bc6
parentf4268b466190dae95a7585f69b4f1f8ad097632c
nfc: llcp: Fix use-after-free race in nfc_llcp_recv_cc()

A race condition exists in the NFC LLCP connection state machine where
the connection acceptance packet (CC) can be processed concurrently with
socket release.  This can lead to a use-after-free of the socket object.

When nfc_llcp_recv_cc() moves the socket from the connecting_sockets
list to the sockets list, it does so without holding the socket lock.
If llcp_sock_release() is executing concurrently, it might have already
unlinked the socket and dropped its references, which can result in
nfc_llcp_recv_cc() linking a freed socket into the live list.

Fix this by holding lock_sock() during the state transition and list
movement in nfc_llcp_recv_cc().  After acquiring the lock, check if
the socket is still hashed to ensure it hasn't already been unlinked
and marked for destruction by the release path.  This aligns the locking
pattern with recv_hdlc() and recv_disc().

Fixes: a69f32af86e3 ("NFC: Socket linked list")
Signed-off-by: Lee Jones <lee@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260429134115.3558604-2-lee@kernel.org
Signed-off-by: David Heidelberg <david@ixit.cz>
net/nfc/llcp_core.c