]> git.ipfire.org Git - thirdparty/git.git/commit
quote: simplify internals of dequoting
authorJeff King <peff@peff.net>
Tue, 19 May 2026 01:20:59 +0000 (21:20 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 19 May 2026 03:14:03 +0000 (12:14 +0900)
commitb56ab270aab71168ab7d0731f0a3853dac7aa62f
tree98eb0080419b205bbdadb41ee17ff7178dc45093
parentc5f52d03e223e1ea0c4639d22ad1ca180ec85097
quote: simplify internals of dequoting

Our sq_dequote_to_argv_internal() helper was wrapped by the to_argv()
and to_strvec() forms. Now that we have only the latter, we can stop
wrapping it and drop the argv-only bits.

Note that in theory sq_dequote_to_strvec() could take a const input
string, which would be friendlier to its callers. We couldn't do that
with the to_argv() form because it reused the input string to hold the
output elements. But since we're built on sq_dequote_step(), which
munges the input, we'd have to rework the parser. Since no callers care
about it currently, we'll leave that for another day.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
quote.c