]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Backpatch tuplesort.c assertion.
authorPeter Geoghegan <pg@bowt.ie>
Wed, 29 Jul 2020 23:00:48 +0000 (16:00 -0700)
committerPeter Geoghegan <pg@bowt.ie>
Wed, 29 Jul 2020 23:00:48 +0000 (16:00 -0700)
commitb6608ae5d3cc16005d4fd4f1be2790e3ad566892
treefbe7de9cc402d97fe8634c9ca255fa70c1a5f1f4
parentaaa132a65deb232125a999184857aaacf3140680
Backpatch tuplesort.c assertion.

Backpatch an assertion (that was originally added to Postgres 12 by
commit dd299df8189) that seems broadly useful.  The assertion can detect
violations of the HOT invariant (i.e. no two index tuples can point to
the same heap TID) when CREATE INDEX somehow incorrectly allows that to
take place.

For example, a IndexBuildHeapScan/heapam_index_build_range_scan bug
might result in two tuples that both point to the same heap TID.  If
these two tuples also happen to be duplicates, the assertion will fail.

Discussion: https://postgr.es/m/CAH2-WzmBxu4o=pMsniur+bwHqCGCmV_AOLkuK6BuU7ngA6evqw@mail.gmail.com
Backpatch: 9.5-11 only
src/backend/utils/sort/tuplesort.c