]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Make stack depth check work with asan's use-after-return
authorAndres Freund <andres@anarazel.de>
Thu, 28 May 2026 15:34:14 +0000 (11:34 -0400)
committerAndres Freund <andres@anarazel.de>
Thu, 28 May 2026 15:34:14 +0000 (11:34 -0400)
commitb67b2cd702725f79ff16b7e01b3d49e54a360a2a
tree17b7a1c581ea066960ee85bfa6fbc57c0261f81e
parent5100bdbd3ba20caf00c8074b61326f80d9255a65
Make stack depth check work with asan's use-after-return

With address sanitizer's stack-use-after-return check, stack variables are
moved to heap allocations, to allow to detect references to the memory at a
later time. That broke our stack-depth check, which is why we had to disable
detect_stack_use_after_return in CI. Luckily __builtin_frame_address() works
correctly, even under asan, so use that.

We started using __builtin_frame_address() with de447bb8e6fb, however as of
that commit we just used it for the stack base address, not for the value to
compare to the base address.  Now we use it for both.

When building without __builtin_frame_address() support, we continue to use
stack variables for the stack depth determination.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/2kk4z4odvuyrg7qlwjd7ft4eron4cle4btb33v4qatgsdkayir@gj6e62rgsel4
Backpatch-through: 14
src/backend/tcop/postgres.c