]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bpf: Fix stack-out-of-bounds write in devmap
authorKohei Enju <kohei@enjuk.jp>
Wed, 25 Feb 2026 05:34:44 +0000 (05:34 +0000)
committerAlexei Starovoitov <ast@kernel.org>
Thu, 26 Feb 2026 19:25:53 +0000 (11:25 -0800)
commitb7bf516c3ecd9a2aae2dc2635178ab87b734fef1
treef2fd502e3507b45230801a267e27d06c679a183b
parentad6fface76da42721c15e8fb281570aaa44a2c01
bpf: Fix stack-out-of-bounds write in devmap

get_upper_ifindexes() iterates over all upper devices and writes their
indices into an array without checking bounds.

Also the callers assume that the max number of upper devices is
MAX_NEST_DEV and allocate excluded_devices[1+MAX_NEST_DEV] on the stack,
but that assumption is not correct and the number of upper devices could
be larger than MAX_NEST_DEV (e.g., many macvlans), causing a
stack-out-of-bounds write.

Add a max parameter to get_upper_ifindexes() to avoid the issue.
When there are too many upper devices, return -EOVERFLOW and abort the
redirect.

To reproduce, create more than MAX_NEST_DEV(8) macvlans on a device with
an XDP program attached using BPF_F_BROADCAST | BPF_F_EXCLUDE_INGRESS.
Then send a packet to the device to trigger the XDP redirect path.

Reported-by: syzbot+10cc7f13760b31bd2e61@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/698c4ce3.050a0220.340abe.000b.GAE@google.com/T/
Fixes: aeea1b86f936 ("bpf, devmap: Exclude XDP broadcast to master device")
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Kohei Enju <kohei@enjuk.jp>
Link: https://lore.kernel.org/r/20260225053506.4738-1-kohei@enjuk.jp
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/devmap.c