]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pci/hotplug/pnv_php: Fix hotplug driver crash on Powernv
authorKrishna Kumar <krishnak@linux.ibm.com>
Mon, 1 Jul 2024 07:45:06 +0000 (13:15 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Sep 2024 09:11:36 +0000 (11:11 +0200)
commitb82d4d5c736f4fd2ed224c35f554f50d1953d21e
treef47ba76b3b2e43cd3018b0a6872a7b8523bf3ad6
parent72377cee3f46cc4aa5d5f445023c6b7f4e1b2d9e
pci/hotplug/pnv_php: Fix hotplug driver crash on Powernv

[ Upstream commit 335e35b748527f0c06ded9eebb65387f60647fda ]

The hotplug driver for powerpc (pci/hotplug/pnv_php.c) causes a kernel
crash when we try to hot-unplug/disable the PCIe switch/bridge from
the PHB.

The crash occurs because although the MSI data structure has been
released during disable/hot-unplug path and it has been assigned
with NULL, still during unregistration the code was again trying to
explicitly disable the MSI which causes the NULL pointer dereference and
kernel crash.

The patch fixes the check during unregistration path to prevent invoking
pci_disable_msi/msix() since its data structure is already freed.

Reported-by: Timothy Pearson <tpearson@raptorengineering.com>
Closes: https://lore.kernel.org/all/1981605666.2142272.1703742465927.JavaMail.zimbra@raptorengineeringinc.com/
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Shawn Anastasio <sanastasio@raptorengineering.com>
Signed-off-by: Krishna Kumar <krishnak@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240701074513.94873-2-krishnak@linux.ibm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/hotplug/pnv_php.c