]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net_sched: sch_fq: clear q->band_pkt_count[] in fq_reset()
authorEric Dumazet <edumazet@google.com>
Wed, 4 Mar 2026 01:56:40 +0000 (01:56 +0000)
committerSasha Levin <sashal@kernel.org>
Thu, 12 Mar 2026 11:09:56 +0000 (07:09 -0400)
commitb86ec45b38daa4ee831dda54903a2084889cfa80
tree93576ba99e56bf63a6be0940b2f961dde8abc4e8
parenteb5904ac5a4dba3e1659e0305741f34bb8589c6e
net_sched: sch_fq: clear q->band_pkt_count[] in fq_reset()

[ Upstream commit a4c2b8be2e5329e7fac6e8f64ddcb8958155cfcb ]

When/if a NIC resets, queues are deactivated by dev_deactivate_many(),
then reactivated when the reset operation completes.

fq_reset() removes all the skbs from various queues.

If we do not clear q->band_pkt_count[], these counters keep growing
and can eventually reach sch->limit, preventing new packets to be queued.

Many thanks to Praveen for discovering the root cause.

Fixes: 29f834aa326e ("net_sched: sch_fq: add 3 bands and WRR scheduling")
Diagnosed-by: Praveen Kaligineedi <pkaligineedi@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20260304015640.961780-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/sch_fq.c