]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
sched_ext: Fix missing warning in scx_set_task_state() default case
authorSamuele Mariotti <smariotti@disroot.org>
Thu, 2 Apr 2026 17:00:25 +0000 (19:00 +0200)
committerTejun Heo <tj@kernel.org>
Thu, 2 Apr 2026 19:22:03 +0000 (09:22 -1000)
commitb905ee77d5f557a83a485b4146210f54f13365fc
treebc388af7e009f0eb76c4c65a54917d68eb926808
parent94555ca6d0bb41a7cb3c12ad2a7cacb6fdbdca0b
sched_ext: Fix missing warning in scx_set_task_state() default case

In scx_set_task_state(), the default case was setting the
warn flag, but then returning immediately. This is problematic
because the only purpose of the warn flag is to trigger
WARN_ONCE, but the early return prevented it from ever firing,
leaving invalid task states undetected and untraced.

To fix this, a WARN_ONCE call is now added directly in the
default case.

The fix addresses two aspects:

 - Guarantees the invalid task states are properly logged
   and traced.

 - Provides a distinct warning message
   ("sched_ext: Invalid task state") specifically for
   states outside the defined scx_task_state enum values,
   making it easier to distinguish from other transition
   warnings.

This ensures proper detection and reporting of invalid states.

Signed-off-by: Samuele Mariotti <smariotti@disroot.org>
Signed-off-by: Paolo Valente <paolo.valente@unimore.it>
Reviewed-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/sched/ext.c