]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: af_alg - Work around empty control messages without MSG_MORE
authorHerbert Xu <herbert@gondor.apana.org.au>
Thu, 27 Aug 2020 07:14:36 +0000 (17:14 +1000)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:22:43 +0000 (18:22 -0400)
commitba1f292491c011fa11d80b152f15ef97e4519891
treeda6b28cba19160d1a4f7b51bb85ec866fc1efcbd
parent546e3961b5d4c6db82cfb441fabb4353940c8f95
crypto: af_alg - Work around empty control messages without MSG_MORE

commit c195d66a8a75c60515819b101975f38b7ec6577f upstream.

The iwd daemon uses libell which sets up the skcipher operation with
two separate control messages.  As the first control message is sent
without MSG_MORE, it is interpreted as an empty request.

While libell should be fixed to use MSG_MORE where appropriate, this
patch works around the bug in the kernel so that existing binaries
continue to work.

We will print a warning however.

A separate issue is that the new kernel code no longer allows the
control message to be sent twice within the same request.  This
restriction is obviously incompatible with what iwd was doing (first
setting an IV and then sending the real control message).  This
patch changes the kernel so that this is explicitly allowed.

Reported-by: Caleb Jorden <caljorden@hotmail.com>
Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when...")
Cc: <stable@vger.kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/af_alg.c