]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/i915/hdcp: check streams[] bounds before overflow
authorJani Nikula <jani.nikula@intel.com>
Thu, 25 Jun 2026 17:03:04 +0000 (20:03 +0300)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Tue, 30 Jun 2026 06:35:49 +0000 (09:35 +0300)
commitbbb15a6b042d02e5508a02b4847e02d2579ee7bc
treecefeb603c1f7e027ce43f40e9ed714d04189b02d
parent1e33f0de5fdcd09e51fdec1e5822448970b6420f
drm/i915/hdcp: check streams[] bounds before overflow

The data->streams[] overflow check is done after the buffer overflow has
already happened. Move the overflow check before the write.

Side note, emitting a warning splat with a backtrace might be overkill
here, but prefer not changing the behaviour other than not doing the
overrun.

Discovered using AI-assisted static analysis confirmed by Intel Product
Security.

Reported-by: Martin Hodo <martin.hodo@intel.com>
Fixes: e03187e12cae ("drm/i915/hdcp: MST streams support in hdcp port_data")
Cc: stable@vger.kernel.org # v5.12+
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
Link: https://patch.msgid.link/20260625170304.1104723-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
(cherry picked from commit 9284ab3b6e776c315883ac2611283d263c9460fd)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/gpu/drm/i915/display/intel_hdcp.c