]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pgstattuple: Fix failure with pgstathashindex() for partitioned indexes
authorMichael Paquier <michael@paquier.xyz>
Tue, 19 Dec 2023 06:20:55 +0000 (15:20 +0900)
committerMichael Paquier <michael@paquier.xyz>
Tue, 19 Dec 2023 06:20:55 +0000 (15:20 +0900)
commitbd2d3c92812f617ebc9b826484fb0d0345571d17
tree81488c6f494c1d60b6f50ae2d3bf49ddd80951d5
parent499342e81b0fba471889439e47e0c37fe9e62bc0
pgstattuple: Fix failure with pgstathashindex() for partitioned indexes

As coded, the function relied on index_open() when opening an index
relation, allowing partitioned indexes to be processed by
pgstathashindex().  This was leading to a "could not open file" error
because partitioned indexes have no physical files, or to a crash with
an assertion failure (like on HEAD).

This issue is fixed by applying the same checks as the other stat
functions for indexes, with a lookup at both RELKIND_INDEX and the index
AM expected.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org
Backpatch-through: 12
contrib/pgstattuple/expected/pgstattuple.out
contrib/pgstattuple/pgstatindex.c
contrib/pgstattuple/sql/pgstattuple.sql