]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ksmbd: fix potencial OOB in get_file_all_info() for compound requests
authorNamjae Jeon <linkinjeon@kernel.org>
Thu, 19 Mar 2026 12:00:02 +0000 (21:00 +0900)
committerSteve French <stfrench@microsoft.com>
Wed, 25 Mar 2026 23:58:40 +0000 (18:58 -0500)
commitbeef2634f81f1c086208191f7228bce1d366493d
tree1813198b3187baef6fe4d2b974079b03ff8f658d
parent0e55f63dd08f09651d39e1b709a91705a8a0ddcb
ksmbd: fix potencial OOB in get_file_all_info() for compound requests

When a compound request consists of QUERY_DIRECTORY + QUERY_INFO
(FILE_ALL_INFORMATION) and the first command consumes nearly the entire
max_trans_size, get_file_all_info() would blindly call smbConvertToUTF16()
with PATH_MAX, causing out-of-bounds write beyond the response buffer.
In get_file_all_info(), there was a missing validation check for
the client-provided OutputBufferLength before copying the filename into
FileName field of the smb2_file_all_info structure.
If the filename length exceeds the available buffer space, it could lead to
potential buffer overflows or memory corruption during smbConvertToUTF16
conversion. This calculating the actual free buffer size using
smb2_calc_max_out_buf_len() and returning -EINVAL if the buffer is
insufficient and updating smbConvertToUTF16 to use the actual filename
length (clamped by PATH_MAX) to ensure a safe copy operation.

Cc: stable@vger.kernel.org
Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound")
Reported-by: Asim Viladi Oglu Manizada <manizada@pm.me>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smb2pdu.c