]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
bnge: Fix resource leak in bnge_init_nic() error path
authorBhargava Marreddy <bhargava.marreddy@broadcom.com>
Wed, 5 Aug 2026 09:40:22 +0000 (15:10 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 6 Aug 2026 16:26:22 +0000 (09:26 -0700)
commitbfec39ff1484b4e9f7d93bc4580fdb634bbc7d19
treef5ee032d5715c1429e743b5c6814970c0cbc65b2
parent6b69f2ef10cdb018c0b127a7cab88e590bbddba4
bnge: Fix resource leak in bnge_init_nic() error path

If bnge_init_chip() fails, bnge_init_nic() jumps to err_free_ring_grps
and returns immediately, skipping cleanup for RX ring pair buffers.

Remove the early return so execution falls through to
err_free_rx_ring_pair_bufs to properly free resources on error.

Fixes: 23df6aebf803 ("bng_en: Allocate stat contexts")
Signed-off-by: Bhargava Marreddy <bhargava.marreddy@broadcom.com>
Reviewed-by: Dharmender Garg <dharmender.garg@broadcom.com>
Reviewed-by: Rajashekar Hudumula <rajashekar.hudumula@broadcom.com>
Link: https://patch.msgid.link/20260805094022.15487-1-bhargava.marreddy@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnge/bnge_netdev.c