]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
binfmt_flat: revert "binfmt_flat: don't offset the data start"
authorMax Filippov <jcmvbkbc@gmail.com>
Sat, 8 Aug 2020 18:37:13 +0000 (11:37 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Aug 2020 07:31:49 +0000 (09:31 +0200)
commitc05dea7c0f3ff1a8d63b41542c4161406093dc2f
tree426ae23f0873ed23912df7d279d6633cbf8df077
parent44f639d5aeda30318fc86aec2fe99581fc24a134
binfmt_flat: revert "binfmt_flat: don't offset the data start"

commit 2217b982624680d19a80ebb4600d05c8586c4f96 upstream.

binfmt_flat loader uses the gap between text and data to store data
segment pointers for the libraries. Even in the absence of shared
libraries it stores at least one pointer to the executable's own data
segment. Text and data can go back to back in the flat binary image and
without offsetting data segment last few instructions in the text
segment may get corrupted by the data segment pointer.

Fix it by reverting commit a2357223c50a ("binfmt_flat: don't offset the
data start").

Cc: stable@vger.kernel.org
Fixes: a2357223c50a ("binfmt_flat: don't offset the data start")
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/binfmt_flat.c