]> git.ipfire.org Git - thirdparty/git.git/commit
range-diff: drop const to fix strstr() warnings
authorJeff King <peff@peff.net>
Thu, 2 Apr 2026 04:15:12 +0000 (00:15 -0400)
committerJunio C Hamano <gitster@pobox.com>
Thu, 2 Apr 2026 05:08:53 +0000 (22:08 -0700)
commitc39512600f85aa88f368dc6bd13baeb183ae52ad
treea644f0caa2d0ad67f127baad43db6ed174140d37
parentd3cd819e8bb21189b7bf3b2718898b610b85b119
range-diff: drop const to fix strstr() warnings

This is another case where we implicitly drop the "const" from a pointer
by feeding it to strstr() and assigning the result to a non-const
pointer. This is OK in practice, since the const pointer originally
comes from a writable source (a strbuf), but C23 libc implementations
have started to complain about it.

We do write to the output pointer, so it needs to remain non-const. We
can just switch the input pointer to also be non-const in this case.  By
itself that would run into problems with calls to skip_prefix(), but
since that function has now been taught to match in/out constness
automatically, it just works without us doing anything further.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
range-diff.c