]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix logical replication TAP test to read publisher log correctly.
authorFujii Masao <fujii@postgresql.org>
Wed, 4 Feb 2026 15:46:09 +0000 (00:46 +0900)
committerFujii Masao <fujii@postgresql.org>
Wed, 4 Feb 2026 15:46:58 +0000 (00:46 +0900)
commitc423bf63a096c47a2829f9c3edda5dde3426fdf6
tree33f023f2fdb9c5b9d1532b2909bc5884d5c86118
parent1662cd0cb7ae42334af17caa7dceb172b45248f7
Fix logical replication TAP test to read publisher log correctly.

Commit 5f13999aa11 added a TAP test for GUC settings passed via the
CONNECTION string in logical replication, but the buildfarm member
sungazer reported test failures.

The test incorrectly used the subscriber's log file position as the
starting offset when reading the publisher's log. As a result, the test
failed to find the expected log message in the publisher's log and
erroneously reported a failure.

This commit fixes the test to use the publisher's own log file position
when reading the publisher's log.

Also, to avoid similar confusion in the future, this commit splits the single
$log_location variable into $log_location_pub and $log_location_sub,
clearly distinguishing publisher and subscriber log positions.

Backpatched to v15, where commit 5f13999aa11 introduced the test.

Per buildfarm member sungazer.
This issue was reported and diagnosed by Alexander Lakhin.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/966ec3d8-1b6f-4f57-ae59-fc7d55bc9a5a@gmail.com
Backpatch-through: 15
src/test/subscription/t/001_rep_changes.pl