]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: hda: Don't release card at firmware loading error
authorTakashi Iwai <tiwai@suse.de>
Mon, 13 Apr 2020 08:20:29 +0000 (10:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Apr 2020 08:30:13 +0000 (10:30 +0200)
commitc8fddc945abac6e5532cf70f16d7c7127304cee1
tree7a7784e1240b11dd1c1002f2593c18d8c625f81b
parent654c9adb64e1bbdccc8cf238087d8eb343f3955f
ALSA: hda: Don't release card at firmware loading error

commit 25faa4bd37c10f19e4b848b9032a17a3d44c6f09 upstream.

At the error path of the firmware loading error, the driver tries to
release the card object and set NULL to drvdata.  This may be referred
badly at the possible PM action, as the driver itself is still bound
and the PM callbacks read the card object.

Instead, we continue the probing as if it were no option set.  This is
often a better choice than the forced abort, too.

Fixes: 5cb543dba986 ("ALSA: hda - Deferred probing with request_firmware_nowait()")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207043
Link: https://lore.kernel.org/r/20200413082034.25166-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/hda/hda_intel.c