]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: ti: omap-dmic: Fix IS_ERR() vs NULL check bug in omap_dmic_select_fclk()
authorIngyu Jang <ingyujang25@korea.ac.kr>
Thu, 14 May 2026 18:52:15 +0000 (03:52 +0900)
committerMark Brown <broonie@kernel.org>
Fri, 15 May 2026 01:53:56 +0000 (10:53 +0900)
commitc996a4418dd4ee45cd086586c04a1103e8160308
tree0b43163b6df6637756328608deff630df11be30f
parentb96fe527935b0671194bc436d7d78d3b0f87b2e1
ASoC: ti: omap-dmic: Fix IS_ERR() vs NULL check bug in omap_dmic_select_fclk()

clk_get_parent() returns NULL when the clock has no parent (or when the
input clk is NULL); it never returns an ERR_PTR. The current IS_ERR(mux)
check therefore never triggers - a NULL return falls through silently
to clk_set_parent(NULL, parent_clk), which simply fails with -EINVAL.

Use a NULL check so the dedicated error path runs and the prior
clk_get() reference is released via clk_put().

Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr>
Acked-by: Sen Wang <sen@ti.com>
Link: https://patch.msgid.link/20260514185215.3753998-1-ingyujang25@korea.ac.kr
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/ti/omap-dmic.c