]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: cs35l56: Suppress pointless warning about number of GPIO pulls
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Thu, 26 Feb 2026 11:35:11 +0000 (11:35 +0000)
committerMark Brown <broonie@kernel.org>
Sun, 1 Mar 2026 23:48:11 +0000 (23:48 +0000)
commitca5056f5a78ce62588878d138e8141f01d70e61b
treefc4af5221546b86399ea211fd00e4f28da3a15af
parentfd13fc700e3e239826a46448bf7f01847dd26f5a
ASoC: cs35l56: Suppress pointless warning about number of GPIO pulls

In cs35l56_process_xu_onchip_speaker_id() the warning that the number
of pulls != number of GPIOs should only be printed if pulls are defined.

Pull settings are optional because there would normally be an external
resistor providing the pull. The warning would still be true if pulls
are not defined, but in that case is just log noise.

While we're changing that block of code, also fix the indenting of the
arguments to the dev_warn().

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20260226113511.1768838-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l56.c