]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ata: libata-scsi: do not use the deferred QC feature for ATA_DEFER_PORT
authorNiklas Cassel <cassel@kernel.org>
Thu, 14 May 2026 07:39:00 +0000 (09:39 +0200)
committerNiklas Cassel <cassel@kernel.org>
Mon, 18 May 2026 10:11:46 +0000 (12:11 +0200)
commitce4548807d2e4ae48fd0dbe38865467369877913
tree5c128ef53894c413d6f7804869504d3864f77fa7
parent360190bd965f93794d5f5685a6de22ce6da2b672
ata: libata-scsi: do not use the deferred QC feature for ATA_DEFER_PORT

The deferred QC feature was meant to handle mixed NCQ and non-NCQ commands,
i.e. for return value ATA_DEFER_LINK.

ATA_DEFER_PORT is returned by PATA drivers, but also certain SATA drivers
like sata_mv and sata_sil24 that uses ap->excl_link to workaround hardware
bugs in these HBAs. Regardless of the reason, using the deferred QC feature
for ATA_DEFER_PORT is always wrong, and will break the ap->excl_link usage
of the SATA drivers that rely on that feature.

Modify ata_scsi_qc_issue() to only use the deferred QC feature when mixing
NCQ and non-NCQ commands, i.e. ATA_DEFER_LINK.

Fixes: 0ea84089dbf6 ("ata: libata-scsi: avoid Non-NCQ command starvation")
Tested-by: Tommy Kelly <linux@tkel.ly>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Niklas Cassel <cassel@kernel.org>
drivers/ata/libata-scsi.c