]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
iio: dac: ad5686: fix input raw value check
authorRodrigo Alencar <rodrigo.alencar@analog.com>
Fri, 1 May 2026 09:14:55 +0000 (10:14 +0100)
committerJonathan Cameron <jic23@kernel.org>
Fri, 15 May 2026 11:05:34 +0000 (12:05 +0100)
commitd01220ee5e43c65a206df827b39bf5cf5f7b9dce
tree2e77fb81a08f03795030c8c2e0e1625e8958ecec
parentecae2ae606d493cf11457946436335bd0e726663
iio: dac: ad5686: fix input raw value check

Fix range check for input raw value, which is off by one, i.e., for a
10-bit DAC the max valid value is 1023, but 1 << 10 equals 1024, which
passes the previous check, allowing an out-of-range write. The issue
exists since the ad5686 driver was first introduced.

Fixes: c2f37c8dcadc ("iio: dac: New driver for AD5686R, AD5685R, AD5684R Digital to analog converters")
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/dac/ad5686.c