]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
xfs: fix superblock inprogress check
authorDave Chinner <dchinner@redhat.com>
Fri, 26 Aug 2016 06:01:30 +0000 (16:01 +1000)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 12 Sep 2016 17:26:47 +0000 (13:26 -0400)
commitd023f70ec430bc8431012e04117eb20d9d334fd1
treeb90e80c25f3b8519d6fcb546196afb0980dcf363
parent206538f128e7e3410e4042f7f15ccb1885adf477
xfs: fix superblock inprogress check

[ Upstream commit f3d7ebdeb2c297bd26272384e955033493ca291c ]

From inspection, the superblock sb_inprogress check is done in the
verifier and triggered only for the primary superblock via a
"bp->b_bn == XFS_SB_DADDR" check.

Unfortunately, the primary superblock is an uncached buffer, and
hence it is configured by xfs_buf_read_uncached() with:

bp->b_bn = XFS_BUF_DADDR_NULL;  /* always null for uncached buffers */

And so this check never triggers. Fix it.

cc: <stable@vger.kernel.org>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
fs/xfs/libxfs/xfs_sb.c