]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfc: nci: complete pending data exchange on device close
authorJakub Kicinski <kuba@kernel.org>
Tue, 3 Mar 2026 16:23:43 +0000 (08:23 -0800)
committerSasha Levin <sashal@kernel.org>
Thu, 12 Mar 2026 11:09:56 +0000 (07:09 -0400)
commitd05f55d68ebdebb2b0a8480d766eaae88c8c92de
tree9c8b661022ee6220a6e97e72b580929a38d7337e
parent54f7f0eaafa56b5994cdb5c7967946922c2e1d22
nfc: nci: complete pending data exchange on device close

[ Upstream commit 66083581945bd5b8e99fe49b5aeb83d03f62d053 ]

In nci_close_device(), complete any pending data exchange before
closing. The data exchange callback (e.g.
rawsock_data_exchange_complete) holds a socket reference.

NIPA occasionally hits this leak:

unreferenced object 0xff1100000f435000 (size 2048):
  comm "nci_dev", pid 3954, jiffies 4295441245
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    27 00 01 40 00 00 00 00 00 00 00 00 00 00 00 00  '..@............
  backtrace (crc ec2b3c5):
    __kmalloc_noprof+0x4db/0x730
    sk_prot_alloc.isra.0+0xe4/0x1d0
    sk_alloc+0x36/0x760
    rawsock_create+0xd1/0x540
    nfc_sock_create+0x11f/0x280
    __sock_create+0x22d/0x630
    __sys_socket+0x115/0x1d0
    __x64_sys_socket+0x72/0xd0
    do_syscall_64+0x117/0xfc0
    entry_SYSCALL_64_after_hwframe+0x4b/0x53

Fixes: 38f04c6b1b68 ("NFC: protect nci_data_exchange transactions")
Reviewed-by: Joe Damato <joe@dama.to>
Link: https://patch.msgid.link/20260303162346.2071888-4-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/nfc/nci/core.c